[pulseaudio-discuss] [PATCH pavucontrol] doc: Adapt the sed expression for cleaning up links

Felipe Sateler fsateler at debian.org
Fri Mar 13 07:59:02 PDT 2015


On 13 March 2015 at 11:45, Alexander E. Patrakov <patrakov at gmail.com> wrote:
> 13.03.2015 18:54, Felipe Sateler wrote:
>>
>> On 13 March 2015 at 10:46, Alexander E. Patrakov <patrakov at gmail.com>
>> wrote:
>>>
>>> Some lynx versions produce links of the form file:///..., others produce
>>> file://localhost/..., so catch both forms.
>>>
>>> Reported-by: Peter Mattern <matternp at arcor.de>
>>> Signed-off-by: Alexander E. Patrakov <patrakov at gmail.com>
>>> ---
>>>   doc/Makefile.am | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/doc/Makefile.am b/doc/Makefile.am
>>> index d4b50be..06b2b10 100644
>>> --- a/doc/Makefile.am
>>> +++ b/doc/Makefile.am
>>> @@ -25,7 +25,7 @@ CLEANFILES =
>>>
>>>   if USE_LYNX
>>>   README: README.html
>>> -       lynx --dump $^ | sed
>>> 's,file://localhost/.*/doc/README.html,README,' > $@
>>> +       lynx --dump $^ | sed 's,file://.*/doc/README.html,README,' > $@
>>
>>
>> Why not just 'file://.*/doc/README.html' ? I don't think file urls are
>> ever expected to be needed in doc urls.
>>
>
> Sorry, I don't understand what you mean (the added line matches for
> file://.*/doc/README.html, i.e. just what you say that you want).

>
> Could you please submit your version of this patch using git send-email?

No wonder you didn't understand, since what I said made no sense :p. I
misread your patch, and proposed it should do what it is actually
doing.

Sorry for the noise.

-- 

Saludos,
Felipe Sateler


More information about the pulseaudio-discuss mailing list