[pulseaudio-discuss] [PATCH 0/2] Module hook dynarray

Tanu Kaskinen tanu.kaskinen at linux.intel.com
Fri Mar 27 02:45:21 PDT 2015


On Fri, 2015-03-27 at 10:20 +0100, David Henningsson wrote:
> This idea emerged when writing some code a while ago. If accepted, I'll refactor
> some more modules as well.

Seems useful, I'm ok with the idea. I didn't review the code carefully,
but I noticed that you made pa_module_hook_connect() an inline function.
It doesn't seem like an important optimization, and my taste is against
needless cluttering of headers with inline functions, but if your taste
is different, then keep the inline function, I don't want to argue about
this.

-- 
Tanu



More information about the pulseaudio-discuss mailing list