[pulseaudio-discuss] [PATCH 3/8] alsa-mixer: Fill in input and output names

David Henningsson david.henningsson at canonical.com
Wed May 6 03:44:59 PDT 2015



On 2015-05-06 11:39, Tanu Kaskinen wrote:
> On Tue, 2015-05-05 at 17:01 +0200, David Henningsson wrote:
>> diff --git a/src/modules/alsa/alsa-mixer.h b/src/modules/alsa/alsa-mixer.h
>> index ec39fab..232017b 100644
>> --- a/src/modules/alsa/alsa-mixer.h
>> +++ b/src/modules/alsa/alsa-mixer.h
>> @@ -283,6 +283,9 @@ struct pa_alsa_profile {
>>       char *description;
>>       unsigned priority;
>>
>> +    char *input_name;
>> +    char *output_name;
>
> I'm afraid this won't work. A profile may have multiple inputs or
> outputs.
>
> (I didn't do proper review, just happened to notice this.)

There's no fundamental reason it can't work - the field is optional. It 
can be either left empty or filled in with some combination of all 
inputs/outputs.

The current behaviour is to leave it empty, unless the profile is 
unidirectional, in which case one direction will be filled in and the 
other one left empty. (Multiple inputs or outputs are always defined as 
profiles, never through mappings with "auto-profiles=yes".)

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


More information about the pulseaudio-discuss mailing list