[pulseaudio-discuss] [PATCH 00/19] Use hooks instead of subscription for module-dbus-protocol

David Henningsson david.henningsson at canonical.com
Thu May 21 02:11:27 PDT 2015


Ok, so I went through the remaining patches and pushed all but the last 
one (which won't be pushed unless you or someone else comes up with a 
new version of the patch).

I took the liberty of refactoring a few of the patches on the way.

So far, only compile tested - I have a hard time trying to test it properly:

$ dbus-monitor --address "unix:path=/run/user/1000/pulse/dbus-socket"
Failed to register connection to bus at 
unix:path=/run/user/1000/pulse/dbus-socket: Method "Hello" with 
signature "" on interface "org.freedesktop.DBus" doesn't exist

Any ideas?

Thanks for your contribution anyhow, this has been a long standing issue :-)

// David

On 2015-03-19 12:50, Juho Hämäläinen wrote:
> Due to problems with asynchronous subscription system used in the
> module-dbus-protocol, replace all subscription system usage with hooks. There
> are some subscription system events which don't have hook counterparts, for
> those add missing hooks to core hook list.
>
> Juho Hämäläinen (19):
>    dbus: Use hooks for card profile events
>    dbus: Use hooks for client proplist changes
>    dbus: Use hooks for sink and source events
>    dbus: Use hooks for sink-input and source-output events
>    dbus: Use state changed hook for sink-input and source-output rate changes
>    dbus: Use hooks for put and unlink
>    core: Add hooks for default sink and source changes
>    namereg: Fire hooks for default sink and source changes
>    dbus: Use hooks for default sink and source changes
>    core: Add core hooks for module changes
>    module: Fire hooks for new, proplist changed and removed
>    core: Add core hooks for sample cache
>    core-scache: Fire hooks for new, changed and removed events
>    dbus: Use hooks for sample cache new and removed events
>    dbus: Use hook for sample cache proplist changes
>    dbus: Use hooks for module new and removed events
>    dbus: Use hooks for module proplist changes
>    Revert "Warn on loading module-dbus-protocol"
>    dbus: Add card profile availability info to API
>
>   src/modules/dbus/iface-card-profile.c   |  19 +
>   src/modules/dbus/iface-card.c           | 120 ++++--
>   src/modules/dbus/iface-client.c         |  34 +-
>   src/modules/dbus/iface-core.c           | 653 ++++++++++++++++++++------------
>   src/modules/dbus/iface-device.c         | 121 ++++--
>   src/modules/dbus/iface-module.c         |  41 +-
>   src/modules/dbus/iface-sample.c         |  41 +-
>   src/modules/dbus/iface-stream.c         | 179 ++++++---
>   src/modules/dbus/module-dbus-protocol.c |   5 -
>   src/pulsecore/core-scache.c             |  26 +-
>   src/pulsecore/core.h                    |   8 +
>   src/pulsecore/module.c                  |   4 +
>   src/pulsecore/namereg.c                 |   2 +
>   13 files changed, 814 insertions(+), 439 deletions(-)
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


More information about the pulseaudio-discuss mailing list