[pulseaudio-discuss] [PATCH] pulse: Document pa_mainloop_quit()'s retval parameter

Tanu Kaskinen tanuk at iki.fi
Fri May 22 12:50:07 PDT 2015


On Thu, May 21, 2015, at 02:46, Peter Meerwald wrote:
> From: Peter Meerwald <p.meerwald at bct-electronic.com>
> 
> Signed-off-by: Peter Meerwald <pmeerw at pmeerw.net>
> ---
>  src/pulse/mainloop.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/pulse/mainloop.h b/src/pulse/mainloop.h
> index a110541..6e2ca5f 100644
> --- a/src/pulse/mainloop.h
> +++ b/src/pulse/mainloop.h
> @@ -114,8 +114,8 @@ int pa_mainloop_run(pa_mainloop *m, int *retval);
>      and is destroyed when the loop is freed. */
>  pa_mainloop_api* pa_mainloop_get_api(pa_mainloop*m);
>  
> -/** Shutdown the main loop */
> -void pa_mainloop_quit(pa_mainloop *m, int r);
> +/** Shutdown the main loop with the specified return value */
> +void pa_mainloop_quit(pa_mainloop *m, int retval);
>  
>  /** Interrupt a running poll (for threaded systems) */
>  void pa_mainloop_wakeup(pa_mainloop *m);

Looks good to me. I was about to complain about not updating the
parameter name also in mainloop.c, but it seems that it's already named
"retval" in mainloop.c :)

-- 
Tanu


More information about the pulseaudio-discuss mailing list