[pulseaudio-discuss] [PATCH 1/2] padsp: Fix wrong condition discovered by -Wlogical-not-parentheses warning

[Peter Meerwald]

warnings emited by gcc 5.1:

utils/padsp.c: In function 'dsp_trigger':
utils/padsp.c:1902:39: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
     while (!pa_operation_get_state(o) != PA_OPERATION_DONE) {
                                       ^
utils/padsp.c: In function 'dsp_cork':
utils/padsp.c:1937:39: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
     while (!pa_operation_get_state(o) != PA_OPERATION_DONE) {
                                       ^
Signed-off-by: Peter Meerwald <pmeerw at pmeerw.net>
---
 src/utils/padsp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/utils/padsp.c b/src/utils/padsp.c
index e61373c..b696b39 100644
--- a/src/utils/padsp.c
+++ b/src/utils/padsp.c
@@ -1899,7 +1899,7 @@ static int dsp_trigger(fd_info *i) {
     }
 
     i->operation_success = 0;
-    while (!pa_operation_get_state(o) != PA_OPERATION_DONE) {
+    while (pa_operation_get_state(o) != PA_OPERATION_DONE) {
         PLAYBACK_STREAM_CHECK_DEAD_GOTO(i, fail);
 
         pa_threaded_mainloop_wait(i->mainloop);
@@ -1934,7 +1934,7 @@ static int dsp_cork(fd_info *i, pa_stream *s, int b) {
     }
 
     i->operation_success = 0;
-    while (!pa_operation_get_state(o) != PA_OPERATION_DONE) {
+    while (pa_operation_get_state(o) != PA_OPERATION_DONE) {
         if (s == i->play_stream)
             PLAYBACK_STREAM_CHECK_DEAD_GOTO(i, fail);
         else if (s == i->rec_stream)
-- 
1.9.1