[pulseaudio-discuss] [PATCH] resampler: Don't expose soxr methods if they are not supported

[David Henningsson]

On 2015-11-06 06:45, arun at accosted.net wrote:
> From: Arun Raghavan <git at arunraghavan.net>
>
> Fixes: https://bugs.freedesktop.org/show_bug.cgi?id=92780
> ---
>   src/pulsecore/resampler.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/src/pulsecore/resampler.c b/src/pulsecore/resampler.c
> index bf3fdb8..df2458d 100644
> --- a/src/pulsecore/resampler.c
> +++ b/src/pulsecore/resampler.c
> @@ -655,9 +655,11 @@ static const char * const resample_methods[] = {
>       "auto",
>       "copy",
>       "peaks",
> +#ifdef HAVE_SOXR
>       "soxr-mq",
>       "soxr-hq",
>       "soxr-vhq"
> +#endif

Eh, no? Shouldn't the resample_methods array follow the 
pa_resample_method_t enum? (Where the SOXR stuff is always exposed, and 
probably should be?)

>   };
>
>   const char *pa_resample_method_to_string(pa_resample_method_t m) {
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic