[pulseaudio-discuss] [PATCH 1/7] alsa-ucm: fix pa_device_port.profiles leak

David Henningsson david.henningsson at canonical.com
Mon Oct 26 02:18:11 PDT 2015


Pushed, thanks. (This one makes sense independently of other patches.)

Also noted that it looks lik Patchwork actually picked it up:

remote: I: 1 patch(es) updated to state Accepted.

...but the patch still lists as "New" in 
http://patchwork.freedesktop.org/patch/62756/

// David

On 2015-10-23 12:56, Tanu Kaskinen wrote:
> pa_device_port.profiles is initialized in pa_device_port_new(), so no
> need to do that in alsa-ucm.c.
> ---
>   src/modules/alsa/alsa-ucm.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/modules/alsa/alsa-ucm.c b/src/modules/alsa/alsa-ucm.c
> index ff5693d..42f3242 100644
> --- a/src/modules/alsa/alsa-ucm.c
> +++ b/src/modules/alsa/alsa-ucm.c
> @@ -778,7 +778,6 @@ static void ucm_add_port_combination(
>
>           pa_hashmap_put(ports, port->name, port);
>           pa_log_debug("Add port %s: %s", port->name, port->description);
> -        port->profiles = pa_hashmap_new(pa_idxset_string_hash_func, pa_idxset_string_compare_func);
>       }
>
>       port->priority = priority;
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic


More information about the pulseaudio-discuss mailing list