[pulseaudio-discuss] [PATCH] module: Always remove freed module from modules_pending_unload

Tanu Kaskinen tanuk at iki.fi
Thu Sep 3 01:46:14 PDT 2015


On Thu, 2015-09-03 at 09:43 +0200, David Henningsson wrote:
> pa_module_free is called from more than one place, not all of
> these places correctly removed the module from the
> modules_pending_unload array, potentially causing a dangling pointer
> in that array.
> 
> Signed-off-by: David Henningsson <david.henningsson at canonical.com>
> ---
> 
> This was found while investigating Pierre's latest comment in
> https://bugs.freedesktop.org/show_bug.cgi?id=90108
> 
> Pierre, can you see if this solves the problem for you?
> 
>  src/pulsecore/module.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Looks good to me.

-- 
Tanu


More information about the pulseaudio-discuss mailing list