[pulseaudio-discuss] [PATCH 1/3] Fix return code check of pa_append_to_home_dir
Peter Meerwald
pmeerw at pmeerw.net
Fri Sep 11 00:07:02 PDT 2015
> It returns negative on error, zero on success.
> Found by coverity
could you link the Coverity ID for the issue?
> ---
> src/pulse/client-conf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/pulse/client-conf.c b/src/pulse/client-conf.c
> index 83331f8..47fe183 100644
> --- a/src/pulse/client-conf.c
> +++ b/src/pulse/client-conf.c
> @@ -212,7 +212,7 @@ int pa_client_conf_load_cookie(pa_client_conf *c, uint8_t *cookie, size_t cookie
> if (r >= 0)
> return 0;
>
> - if (pa_append_to_home_dir(PA_NATIVE_COOKIE_FILE_FALLBACK, &fallback_path) > 0) {
> + if (pa_append_to_home_dir(PA_NATIVE_COOKIE_FILE_FALLBACK, &fallback_path) >= 0) {
> r = pa_authkey_load(fallback_path, false, cookie, cookie_length);
> pa_xfree(fallback_path);
> if (r >= 0)
> --
> 2.5.1
>
> _______________________________________________
> pulseaudio-discuss mailing list
> pulseaudio-discuss at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/pulseaudio-discuss
>
--
Peter Meerwald
+43-664-2444418 (mobile)
More information about the pulseaudio-discuss
mailing list