[pulseaudio-discuss] [PATCH RESEND] loopback: Fix the obviously-wrong "buffer+=buffer" logic

Tanu Kaskinen tanuk at iki.fi
Sun Sep 13 09:36:51 PDT 2015


On Sat, 2015-09-12 at 19:27 +0500, Alexander E. Patrakov wrote:
> Originally pointed out by Georg Chini.
> 
> Calculating buffer = buffer + (send_counter - recv_counter)
> in one branch and buffer = 2 * buffer - (recv_counter - send_counter)
> looks very obviously wrong. In other words, before the patch, the 
> contribution from the previous lines was double-counted.
> 
> ---
>  src/modules/module-loopback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> This is a resend of
> http://article.gmane.org/gmane.comp.audio.pulseaudio.general/22951 an
> d 
> http://article.gmane.org/gmane.comp.audio.pulseaudio.general/22913
> 
> No Signed-off-by line, because the original patch by Georg Chini did
> not have one.
> 
> The equivalent fix has been already applied to module-echo-cancel in
> commit
> 7c223a6565551cb18ef9db8930b0ce4eced7336c

Thanks! Applied, and sorry for neglecting this patch earlier.

-- 
Tanu


More information about the pulseaudio-discuss mailing list