[pulseaudio-discuss] [PATCH 0/8] patches addressing some Coverity issues

[Arun Raghavan]

On Mon, 2015-09-14 at 18:07 +0200, Peter Meerwald wrote:
> From: Peter Meerwald <p.meerwald at bct-electronic.com>
> 
> nota bene: put the following in user_nodefs.h in the cov
> -analysis/config
> directory to address pa_assert_se() false alarms:
> 
> #nodef pa_assert_se(x) do { int y = x ; if (!(y))
> __coverity_panic__(); } while (0)
> 
> fix assorted issues, more to come...
> 
> Peter Meerwald (8):
>   modules: Fix unchecked return in module-card-restore
>   modules: Fix dead code in oss-util
>   core: Assert that memblockq's base is != 0
>   tests: Assert fillrate > 0 in alsa-time-test
>   daemon: No need to check optarg, -p requires argument
>   modules: Fix entry leak in module-card-restore
>   modules: Cleanup get_sinks() in module-equalizer-sink
>   core: Add missing return on protocol error
> 
>  src/daemon/cmdline.c                |    2 +-
>  src/modules/module-card-restore.c   |    4 +++-
>  src/modules/module-equalizer-sink.c |   14 +++++++-------
>  src/modules/oss/oss-util.c          |    2 +-
>  src/pulsecore/memblockq.c           |    2 +-
>  src/pulsecore/protocol-native.c     |    4 +++-
>  src/tests/alsa-time-test.c          |    1 +
>  7 files changed, 17 insertions(+), 12 deletions(-)

Looks good other than the 2 comments I've already sent.

-- Arun