[pulseaudio-discuss] [PATCH v2 04/12] daemon: No need to check optarg, -p requires argument

Peter Meerwald pmeerw at pmeerw.net
Tue Sep 15 15:01:42 PDT 2015


From: Peter Meerwald <p.meerwald at bct-electronic.com>

CID 1323589

getopt() makes sure that we have an argument for -p
remove the broken check for optarg being set
---
 src/daemon/cmdline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/daemon/cmdline.c b/src/daemon/cmdline.c
index a2fb6d5..68a02e3 100644
--- a/src/daemon/cmdline.c
+++ b/src/daemon/cmdline.c
@@ -312,7 +312,7 @@ int pa_cmdline_parse(pa_daemon_conf *conf, int argc, char *const argv [], int *d
             case 'p':
             case ARG_DL_SEARCH_PATH:
                 pa_xfree(conf->dl_search_path);
-                conf->dl_search_path = *optarg ? pa_xstrdup(optarg) : NULL;
+                conf->dl_search_path = pa_xstrdup(optarg);
                 break;
 
             case 'n':
-- 
1.9.1



More information about the pulseaudio-discuss mailing list