[pulseaudio-discuss] [PATCH v2 00/12] patches addressing some Coverity issues

[Peter Meerwald]

nota bene: put the following in user_nodefs.h in the cov-analysis/config
directory to address pa_assert_se() false alarms:

 #nodef pa_assert_se(x) do { int y = x ; if (!(y)) __coverity_panic__(); } while (0)

fix assorted issues, more to come...

v2 fixes the incomplete 'modules: Fix entry leak in module-card-restore' and drops
'modules: Fix dead code in oss-util' (thanks, Arun)

v2 adds patch 8 to 12

I intend to apply 
'daemon: No need to check optarg, -p requires argument'
'modules: Fix entry leak in module-card-restore'
'core: Add missing return on protocol error'
to master soonish

the remaining patches will go to next after review

Peter Meerwald (12):
  modules: Fix unchecked return in module-card-restore
  core: Assert that memblockq's base is != 0
  tests: Assert fillrate > 0 in alsa-time-test
  daemon: No need to check optarg, -p requires argument
  modules: Fix entry leak in module-card-restore
  modules: Cleanup get_sinks() in module-equalizer-sink
  core: Add missing return on protocol error
  modules: Use pa_assert_se() to check return value of
    dbus_message_iter_close_container()
  modules: Check pa_threaded_mainloop_start() return value
  tests: Check pa_rtpoll_run() return value
  stream: Check pa_tagstruct_get_format_info() retval in
    pa_create_stream_callback()
  alsa: Check pa_modargs_get_value_boolean() retval for use_ucm

 src/daemon/cmdline.c                  |  2 +-
 src/modules/alsa/module-alsa-card.c   |  6 +++++-
 src/modules/module-card-restore.c     |  8 ++++++--
 src/modules/module-equalizer-sink.c   | 14 +++++++-------
 src/modules/module-ladspa-sink.c      |  2 +-
 src/modules/module-zeroconf-publish.c |  3 ++-
 src/pulse/stream.c                    |  8 +++-----
 src/pulsecore/memblockq.c             |  2 +-
 src/pulsecore/protocol-native.c       |  4 +++-
 src/tests/alsa-time-test.c            |  1 +
 src/tests/rtpoll-test.c               |  4 ++--
 11 files changed, 32 insertions(+), 22 deletions(-)

-- 
1.9.1