[pulseaudio-discuss] [PATCH v2 04/12] daemon: No need to check optarg, -p requires argument

[Peter Meerwald]

Hello Tanu,

> > > > > CID 1323589
> > so the patch only changes behaviour if somehow dlsearchpath is NOT NULL 
> > initially (doesn't seem to be the case) and -p "" is given; and I think 
> > the patch improves the situation: the explicit -p "" leads to 
> > lt_dlsetsearchpath("") actually being called and not ignored
> > 
> > 
> > sorry for the mess at an inappropriate time, the commit message totally 
> > doesn't reflect above findings (which I became aware of after the fact :)
> > 
> > I suggest to keep the patch
> 
> I agree, no need to revert. What was the issue that Coverity was
> worried about? Should I create an account at coverity.com and somehow
> look up the CID?

don't, we need a clean, unbiased mind to review those patches :)

the message is: Dereference after null check (FORWARD_NULL)
Dereference null pointer optarg

it somehow believes that optarg can be NULL, I don't think the automatic 
analysis is accurate is this case

regards, p.

-- 

Peter Meerwald
+43-664-2444418 (mobile)