[pulseaudio-discuss] [PATCH] build-sys: fix the default bash completion directory

[Arun Raghavan]

On 27-Sep-2015 19:18, "Tanu Kaskinen" <tanuk at iki.fi> wrote:
>
> If bashcompletiondir was empty, the check didn't catch that. As
> a result, the symlinks that were supposed to be generated in the
> completion directory were created in the root directory.
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure.ac b/configure.ac
> index fa8ea1c..f777223 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1439,7 +1439,7 @@ AC_SUBST(udevrulesdir)
>  AC_ARG_WITH([bash-completion-dir],
>          AS_HELP_STRING([--with-bash-completion-dir=DIR], [Directory for
bash completion files]),
>          [bashcompletiondir=$withval], [bashcompletiondir=$($PKG_CONFIG
--variable=completionsdir bash-completion)])
> -if test "x$bashcompletionsdir" = ""; then
> +if test "x$bashcompletionsdir" = "x"; then
>         bashcompletiondir="${datadir}/bash-completion/completions"
>  fi

Ack.

-- Arun
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20150927/e0ca6571/attachment.html>