[pulseaudio-discuss] [PATCH] build-sys: fix PULSE_LOCALEDIR definition

[Tanu Kaskinen]

On Tue, 2015-09-29 at 15:01 +0200, David Henningsson wrote:
> 
> On 2015-09-29 10:41, Tanu Kaskinen wrote:
> > On some systems (at least Arch) DATADIRNAME is not defined. This
> > caused PULSE_LOCALEDIR to point to a wrong directory. This seemed like
> > an issue introduced in 7.0, but probably something else was updated in
> > Arch at the same time, causing DATADIRNAME to become undefined,
> > because there were no changes between 6.0 and 7.0 that could have
> > caused this.
> 
> I don't know eitehr DATADIRNAME or ${localedir} enough to tell which one 
> is preferred, but it seems like your change now defines PULSE_LOCALEDIR 
> even if "enable_nls" == "no", which is a difference to the current 
> behaviour. Is this intentional?

It's not intentional, but the only place where PULSE_LOCALEDIR is used
is in bindtextdomain() calls, and those are guarded by #ifdef
ENABLE_NLS. So I don't think this is a problem.

-- 
Tanu