[pulseaudio-discuss] [PATCH 3/8] rtp: Drop support for non-L16 media

Tanu Kaskinen tanuk at iki.fi
Tue Apr 12 13:46:10 UTC 2016


On Tue, 2016-04-12 at 09:56 +0530, Arun Raghavan wrote:
> On Mon, 2016-04-11 at 19:23 +0300, Tanu Kaskinen wrote:
> > On Mon, 2016-02-29 at 15:46 +0530, arun at accosted.net wrote:
> > > From: Arun Raghavan <git at arunraghavan.net>
> > > 
> > > There doesn't seem much value in supporting streaming U8/mulaw/alaw on
> > > the network, and it's unlikely these get any testing. Makes more sense
> > > to drop these formats and just convert to L16 if we're dealing with
> > > source media in that format.
>> > It seems likely that the main motivation behind removing the support is
> > not mentioned in the commit message. Something to do with gstreamer?
> 
> Not sure what you mean. These are not likely to be used or tested. I
> didn't want to add a bunch of equivalent kludge in the GStreamer
> backend as well to support the same thing.

That's the context I was looking for. You could add a note about the
relationship with the gstreamer code to the commit message, although
it's fine as it is too.

The code changes look good.

-- 
Tanu


More information about the pulseaudio-discuss mailing list