[pulseaudio-discuss] [PATCH] Add checkbutton for disabling volume meters

Tanu Kaskinen tanuk at iki.fi
Tue Apr 26 15:16:46 UTC 2016


On Sun, 2014-07-20 at 20:33 +0200, Lukas K wrote:
> Add a checkbutton for disabling volume meters because of high CPU
> utilisation when updating them
> ---
>  src/mainwindow.cc          |  52 +++++++++++-
>  src/mainwindow.h           |   2 +
>  src/minimalstreamwidget.cc |  19 ++++-
>  src/minimalstreamwidget.h  |   6 ++
>  src/pavucontrol.glade      | 195 ++++++++++++++++++++++++++-------------------
>  src/streamwidget.cc        |   1 -
>  src/streamwidget.h         |   1 -
>  7 files changed, 190 insertions(+), 86 deletions(-)

Thanks! After a year and half, I finally reviewed this, and the code
looked good for the most part. I added some pa_operation_unref() calls
for the pa_stream_cork() calls, and did some small coding style fixes,
and removed debug prints.

-- 
Tanu


More information about the pulseaudio-discuss mailing list