[pulseaudio-discuss] [PATCH v2 1/7] bluetooth: wait for all profiles to connect before creating card

Tanu Kaskinen tanuk at iki.fi
Wed Aug 10 18:38:38 UTC 2016


On Wed, 2016-08-10 at 20:55 +0530, Arun Raghavan wrote:
> On Sun, 7 Aug 2016, at 09:15 PM, Tanu Kaskinen wrote:
> > 
> > The CONNECTION_CHANGED hook is used to notify the discovery module
> > about new and removed devices. When a bluetooth device connects, the
> > hook used to be called immediately when the first profile connected.
> > That meant that only one profile was marked as available during the
> > card creation, other profiles would get marked as available later.
> > 
> > That makes it hard for module-card-restore to restore the saved
> > profile, if the saved profile becomes available with some delay.
> > module-card-restore has a workaround for this problem, but that turned
> > out to interfere with module-bluetooth-policy, so the workaround will
> > be removed in the next patch.
> > 
> > The BlueZ 4 code doesn't need changes, because we use the
> > org.bluez.Audio interface to get a notification when all profiles are
> > connected.
> > ---
> 
> Except one trivial comment I have below, the first 4 patches of the
> series look okay to me. I'm not too fussed about changes to the bluez4
> side of things, so unless there's something that you'd specifically like
> a second pair of eyes on, if it works, just go ahead and push it.

Thanks, I pushed the patches, with the change you suggested.

-- 
Tanu


More information about the pulseaudio-discuss mailing list