[pulseaudio-discuss] [PATCH 3/3] bluetooth: Fix dead code

Arun Raghavan arun at arunraghavan.net
Tue Aug 16 05:54:51 UTC 2016



On Tue, 16 Aug 2016, at 11:17 AM, Peter Meerwald-Stadler wrote:
> CID 1353115
> 
> Signed-off-by: Peter Meerwald-Stadler <pmeerw at pmeerw.net>
> ---
>  src/modules/bluetooth/module-bluez4-discover.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/src/modules/bluetooth/module-bluez4-discover.c
> b/src/modules/bluetooth/module-bluez4-discover.c
> index e39036a..cac7510 100644
> --- a/src/modules/bluetooth/module-bluez4-discover.c
> +++ b/src/modules/bluetooth/module-bluez4-discover.c
> @@ -124,7 +124,7 @@ static pa_hook_result_t
> load_module_for_device(pa_bluez4_discovery *y, const pa_
>  
>  int pa__init(pa_module* m) {
>      struct userdata *u;
> -    pa_modargs *ma = NULL;
> +    pa_modargs *ma;
>  
>      pa_assert(m);
>  
> @@ -140,7 +140,6 @@ int pa__init(pa_module* m) {
>      u->module = m;
>      u->core = m->core;
>      u->modargs = ma;
> -    ma = NULL;
>      u->hashmap = pa_hashmap_new(pa_idxset_string_hash_func,
>      pa_idxset_string_compare_func);
>  
>      if (!(u->discovery = pa_bluez4_discovery_get(u->core)))
> @@ -154,9 +153,6 @@ int pa__init(pa_module* m) {
>  fail:
>      pa__done(m);
>  
> -    if (ma)
> -        pa_modargs_free(ma);
> -
>      return -1;
>  }
>  
> -- 

Looks good.

-- Arun


More information about the pulseaudio-discuss mailing list