[pulseaudio-discuss] [PATCH 1/2] bluetooth: Fix potential NULL pointer dereference

[Tanu Kaskinen]

On Tue, 2016-08-16 at 16:06 +0200, Peter Meerwald-Stadler wrote:
> From: Peter Meerwald <p.meerwald at bct-electronic.com>
> 
> CID 1353122
> 
> Signed-off-by: Peter Meerwald-Stadler <pmeerw at pmeerw.net>
> ---
>  src/modules/bluetooth/bluez4-util.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/modules/bluetooth/bluez4-util.c
> b/src/modules/bluetooth/bluez4-util.c
> index 3793898..542ce35 100644
> --- a/src/modules/bluetooth/bluez4-util.c
> +++ b/src/modules/bluetooth/bluez4-util.c
> @@ -657,13 +657,13 @@ static void
> get_properties_reply(DBusPendingCall *pending, void *userdata) {
>  
>      pa_assert(p->call_data == d);
>  
> -    if (d != NULL)
> +    if (d != NULL) {
>          old_any_connected = pa_bluez4_device_any_audio_connected(d);
> +        valid = dbus_message_get_type(r) == DBUS_MESSAGE_TYPE_ERROR
> ? -1 : 1;
>  
> -    valid = dbus_message_get_type(r) == DBUS_MESSAGE_TYPE_ERROR ? -1
> : 1;
> -
> -    if (dbus_message_is_method_call(p->message, "org.bluez.Device",
> "GetProperties"))
> -        d->device_info_valid = valid;
> +        if (dbus_message_is_method_call(p->message,
> "org.bluez.Device", "GetProperties"))
> +            d->device_info_valid = valid;
> +    }
>  
>      if (dbus_message_is_error(r, DBUS_ERROR_SERVICE_UNKNOWN)) {
>          pa_log_debug("Bluetooth daemon is apparently not
> available.");

I don't think there's any risk of NULL pointer dereference, so the
commit message needs to be changed. The change itself is fine, though,
if it gets rid of a false positive from Coverity.

-- 
Tanu