[pulseaudio-discuss] [PATCH v6 18/25] loopback: Limit controller step size to 2.01‰

[Tanu Kaskinen]

On Sat, 2016-08-20 at 17:39 +0200, Georg Chini wrote:
> On 20.08.2016 17:24, Tanu Kaskinen wrote:
> > 
> > On Sun, 2016-06-05 at 21:05 +0200, Georg Chini wrote:
> > > 
> > > The current loopback controller can produce a rate jump of up to 1% at startup. This
> > > might be audible, so implement a similar controller that will be used in the initial
> > > iterations and has a 2‰ limit to the step size. Once the original controller takes
> > > over, step size is limited to 2.01‰. Proof for this can be found in the document
> > > "rate_estimator.odt" mentioned previously.
> > When referencing the document, you should provide a link. I can upload
> > it to the freedesktop web server, unless you have better ideas.
> 
> Thanks, please provide the link.

https://www.freedesktop.org/software/pulseaudio/misc/rate_estimator.odt

> > The .01 part in the number looks weird - I'd like the comments in
> > the
> > code to answer the question why the limit is not a nice round
> > number.
> > 
> Would something like "The value of 2.01‰ can be calculated from
> the maximum deviation of 1%" be sufficient? There is no easy way
> the calculation itself can be explained in a few sentences, that is why
> I referenced the document. When I have a link, I can also reference
> the document directly in the code.

Well, I don't understand where that 1% deviation comes from, so I don't
think that comment is very useful. If it can't be explained in more
convenient way, you can reference the document in the comments.

-- 
Tanu