[pulseaudio-discuss] [PATCH] Use local icon for zeroconf shared devices

Tanu Kaskinen tanuk at iki.fi
Wed Aug 31 20:32:11 UTC 2016


On Wed, 2016-08-31 at 01:21 +0200, Sylvain Baubeau wrote:
> 2016-08-28 16:30 GMT+02:00 Tanu Kaskinen <tanuk at iki.fi>:
> 
> > 
> > On Fri, 2016-08-26 at 18:22 +0200, Sylvain Baubeau wrote:
> > > 
> > > systemd-hostnamed provides an icon for the machine it is running on.
> > > With this patch, module-zeroconf-publish uses this icon for the
> > > 'icon-name' attribute in the Avahi properties. module-zeroconf-discover
> > > passes this icon to module-tunnel using the module parameter
> > > {sink/source}_properties.
> > > 
> > > This allows to display a portable, desktop or phone instead of
> > > the generic sound card icon.
> > 
> > This also overrides the device icon when it's *not* a generic sound
> > card icon. But I guess this is in most cases better, since the good
> > icon names tend to be associated with ports, not sinks.
> > 
> 
> Without this patch, module-zeroconf-publish sets the Avahi property
> device.icon-name but this icon does not seem to be used by
> module-zeroconf-discover. On my machine, the sinks end up having
> the icon-name "audio-card" and "audio-card-input" that seem to be
> the default icons for sinks.

Yes, my mistake, I misremembered that all remote sink properties would
get copied to the tunnel sink (I once wrote a patch for that, but it
never got merged).

-- 
Tanu


More information about the pulseaudio-discuss mailing list