[pulseaudio-discuss] [PATCH 1/2] Revert "memblockq: remove internal "missing" state variable"

Tanu Kaskinen tanuk at iki.fi
Thu Dec 29 20:29:59 UTC 2016

On Wed, 2016-12-28 at 19:21 +0200, Ahmed S. Darwish wrote:
> On Wed, Dec 28, 2016 at 04:09:54PM +0200, Tanu Kaskinen wrote:
> > This reverts commit 74251f07864c63439ea847d7287024ac54578d64.
> > 
> > The reverted commit was not intended to make any behavioral changes, but
> > it broke at least the case where a client writes more data than the
> > server has requested.
> > 
> > BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=99211
> > ---

Thanks, I pushed this now. I noticed that memblockq-test started
failing, though. As far as I can see, it's a bug in the test. Fixing it
isn't complicated as such, but I want to add some additional comments
to the test, and also remove pa_memblockq_missing() because that
function is only used in memblockq-test and its definition of "missing"
is different from pa_memblockq_pop_missing(). I'll send patches
tomorrow (or maybe today, but probably tomorrow).



More information about the pulseaudio-discuss mailing list