[pulseaudio-discuss] [PATCH 1/3] build-sys: Drop sysroot from OS X CFLAGS

[Mihai Moldovan]

On 04.01.2016 08:15 AM, arun at accosted.net wrote:
> From: Arun Raghavan <git at arunraghavan.net>
> 
> Doesn't seem to be required (any more?).
> ---
>  configure.ac | 8 ++------
>  1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/configure.ac b/configure.ac
> index ee1b437..9563d66 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1355,13 +1355,9 @@ AC_ARG_WITH(mac-version-min,
>      AS_HELP_STRING([--with-mac-version-min=<version>], [Defines the earliest version of MacOS X that the executables will run on.]),
>      mac_version_min=$withval, mac_version_min="10.5")
>  
> -AC_ARG_WITH(mac-sysroot,
> -    AS_HELP_STRING([--with-mac-sysroot=<path>], [SDK basedir to use as the logical root directory for headers and libraries.]),
> -    mac_sysroot=$withval, mac_sysroot="/Developer/SDKs/MacOSX10.5.sdk")


FWIW, I wouldn't drop it, as long as it doesn't hurt. -isysroot is still widely
supported and sysrooting a general concept on OS X to select a specific SDK.
Without it, packagers and users would need to specify the flag explicitly. Not a
big deal, really, but why get rid of it if it's sanctioned and working fine?

Only the default value is outdated nowadays. I guess we can't (and should not)
really give a default value here, because nowadays with newer Xcode versions the
SDKs reside within the Xcode.app bundle, which can be moved around freely.
Normally it's in /Applications/Xcode.app, but there's nothing preventing users
from renaming or relocating it (for instance to install different versions of
Xcode concurrently.)



Mihai

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 884 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20160212/09343824/attachment.sig>