[pulseaudio-discuss] [PATCH 1/2] modules: Fix compiler warning comparing 0 with bool

[David Henningsson]

Ack

On 2016-02-16 00:15, Peter Meerwald wrote:
> modules/module-stream-restore.c: In function 'clean_up_db':
> modules/module-stream-restore.c:2344:74: warning: comparison of constant '0' with boolean expression is always true [-Wbool-compare]
>           pa_assert_se(entry_write(u, item->entry_name, item->entry, true) >= 0);
>
> reported by Ubuntu gcc-6
>
> Signed-off-by: Peter Meerwald <pmeerw at pmeerw.net>
> ---
>   src/modules/module-stream-restore.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/modules/module-stream-restore.c b/src/modules/module-stream-restore.c
> index ac51ff3..37555a8 100644
> --- a/src/modules/module-stream-restore.c
> +++ b/src/modules/module-stream-restore.c
> @@ -2341,7 +2341,7 @@ static void clean_up_db(struct userdata *u) {
>       PA_LLIST_FOREACH_SAFE(item, next, to_be_converted) {
>           pa_log_debug("Upgrading a legacy entry to the current format: %s", item->entry_name);
>
> -        pa_assert_se(entry_write(u, item->entry_name, item->entry, true) >= 0);
> +        pa_assert_se(entry_write(u, item->entry_name, item->entry, true));
>           trigger_save(u);
>
>           PA_LLIST_REMOVE(struct clean_up_item, to_be_converted, item);
>

-- 
David Henningsson, Canonical Ltd.
https://launchpad.net/~diwic