[pulseaudio-discuss] [PATCH] role-cork: Use the PA_IDXSET_FOREACH macro

Arun Raghavan arun at accosted.net
Thu Feb 18 05:59:03 UTC 2016


On Thu, 2016-02-18 at 00:12 +0900, 이정섭 wrote:
> Simplify code by using PA_IDXSET_FOREACH.
> 
> Signed-off-by: Jungsup Lee <jungsup4.lee at samsung.com>
> ---
>  src/modules/module-role-cork.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/src/modules/module-role-cork.c b/src/modules/module-role-cork.c
> index 7c0f59f..4ae2005 100644
> --- a/src/modules/module-role-cork.c
> +++ b/src/modules/module-role-cork.c
> @@ -70,7 +70,7 @@ static bool shall_cork(struct userdata *u, pa_sink
> *s, pa_sink_input *ignore) {
>      pa_assert(u);
>      pa_sink_assert_ref(s);
> 
> -    for (j = PA_SINK_INPUT(pa_idxset_first(s->inputs, &idx)); j; j =
> PA_SINK_INPUT(pa_idxset_next(s->inputs, &idx))) {
> +    PA_IDXSET_FOREACH(j, s->inputs, idx) {

Your mail client wrapped this line, so the patch won't apply. You might
want to take a look at git send-email to make this process easier.

-- Arun



More information about the pulseaudio-discuss mailing list