[pulseaudio-discuss] [PATCH v4 17/23] echo-cancel: Improve webrtc canceller error handling a bit

Tanu Kaskinen tanuk at iki.fi
Sat Feb 20 12:53:29 UTC 2016


On Wed, 2016-02-17 at 19:47 +0530, arun at accosted.net wrote:
> @@ -363,7 +367,8 @@ void pa_webrtc_ec_play(pa_echo_canceller *ec, const uint8_t *play) {
>      pa_assert(play_frame.samples_per_channel_ <= webrtc::AudioFrame::kMaxDataSizeSamples);
>      memcpy(play_frame.data_, play, ec->params.webrtc.blocksize * pa_frame_size(ss));
>  
> -    apm->ProcessReverseStream(&play_frame);
> +    if (apm->ProcessReverseStream(&play_frame) != webrtc::AudioProcessing::kNoError)
> +        pa_log("Failed to process playback stream");

This should have been changed to an assertion too. I have it changed in
my local tree.

-- 
Tanu


More information about the pulseaudio-discuss mailing list