[pulseaudio-discuss] [PATCH v3 04/24] echo-cancel: Use correct sample spec parameters for webrtc AEC init

[Arun Raghavan]

On 25 January 2016 at 13:56, Tanu Kaskinen <tanuk at iki.fi> wrote:
> On Mon, 2016-01-18 at 13:06 +0530, arun at accosted.net wrote:
>
>> From: Arun Raghavan <git at arunraghavan.net>
>>
>> ---
>>  src/modules/echo-cancel/webrtc.cc | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/src/modules/echo-cancel/webrtc.cc b/src/modules/echo-cancel/webrtc.cc
>> index bbfa43f..ec63e26 100644
>> --- a/src/modules/echo-cancel/webrtc.cc
>> +++ b/src/modules/echo-cancel/webrtc.cc
>> @@ -187,10 +187,10 @@ bool pa_webrtc_ec_init(pa_core *c, pa_echo_canceller *ec,
>>      *rec_map = *out_map;
>>
>>      pconfig = {
>> -        webrtc::StreamConfig(out_ss->rate, out_ss->channels, false), /* input stream */
>> +        webrtc::StreamConfig(rec_ss->rate, rec_ss->channels, false), /* input stream */
>>          webrtc::StreamConfig(out_ss->rate, out_ss->channels, false), /* output stream */
>> -        webrtc::StreamConfig(out_ss->rate, out_ss->channels, false), /* reverse input stream */
>> -        webrtc::StreamConfig(out_ss->rate, out_ss->channels, false), /* reverse output stream */
>> +        webrtc::StreamConfig(play_ss->rate, play_ss->channels, false), /* reverse input stream */
>> +        webrtc::StreamConfig(play_ss->rate, play_ss->channels, false), /* reverse output stream */
>>      };
>>      apm->Initialize(pconfig);
>
> Shouldn't this be fixed in patch 1?

Not sure why I didn't while squashing the others. Will do so.

-- Arun