[pulseaudio-discuss] [PATCH] daemon: Tone down system mode snarkiness
Tanu Kaskinen
tanuk at iki.fi
Thu Jul 14 15:43:50 UTC 2016
On Thu, 2016-07-14 at 11:38 +0900, Arun Raghavan wrote:
> We do support system mode for the cases where it makes sense, so it's
> really not sensible to be unconditionally snarky at our users for doing
> it.
>
> Signed-off-by: Arun Raghavan <arun at arunraghavan.net>
> ---
> src/daemon/main.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/src/daemon/main.c b/src/daemon/main.c
> index a5faba5..15b862e 100644
> --- a/src/daemon/main.c
> +++ b/src/daemon/main.c
> @@ -972,8 +972,7 @@ int main(int argc, char *argv[]) {
> pa_log_info("Running in system mode: %s", pa_yes_no(pa_in_system_mode()));
>
> if (pa_in_system_mode())
> - pa_log_warn(_("OK, so you are running PA in system mode. Please note that you most likely shouldn't be doing that.\n"
> - "If you do it nonetheless then it's your own fault if things don't work as expected.\n"
> + pa_log_warn(_("OK, so you are running PA in system mode. Please make sure that you actually do want to do that.\n"
> "Please read http://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/WhatIsWrongWithSystemWide/ for an explanation why system mode is usually a bad idea."));
>
> if (conf->use_pid_file) {
I see you also improved the wiki - thank you! I pushed this patch.
--
Tanu
More information about the pulseaudio-discuss
mailing list