[pulseaudio-discuss] [PATCH 4/6] PROTOCOL: Added PA_COMMAND_SET_(SINK|SOURCE)_LATENCY_OFFSET

[Chris Billington]

Thanks Tanu,

I'm on something of a deadline writing a thesis before moving country, so I
won't be able to get back to this for probably about two months. But I
don't plan on abandoning it since I use this functionality daily to stream
audio in my house.

I'll implement querying of latency offsets and bump the version number to
whatever it is at the time I get back to it.

Thanks for looking at it,

Chris

On Fri, Jul 15, 2016 at 4:29 AM, Tanu Kaskinen <tanuk at iki.fi> wrote:

> On Sat, 2016-01-23 at 12:31 +1100, Chris Billington wrote:
> > Bumped protocol version number to 31.
>
> As time has passed by, the version should now be bumped to 32.
>
> > These commands allow applications to set the latency offset of individual
> > sources and sinks, using functionality introduced in the last commit.
> >
> > This is useful for setting the latency offset of a source or sink that
> is not
> > tied to a particular port, such as a null sink being used to capture
> output
> > and stream it over a network. If the application doing this knows the
> network
> > latency, then it can use these new protocol commands to inform
> PulseAudio of
> > it, so that video and audio may remain in sync.
>
> I noticed that neither this patch nor any other patch implements
> querying the sink/source latency offset. I think it's pretty important
> to be able to also query the current offsets, if there's a mechanism
> for setting the offsets.
>
> Adding the querying support should be pretty simple. Basically you just
> need to add a new field to the pa_sink/source_info struct and send the
> value in the GET_SINK/SOURCE_INFO command. pactl should be updated too
> to print the value in the "list sinks/sources" commands.
>
> This patch looks good otherwise.
>
> --
> Tanu
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/pulseaudio-discuss/attachments/20160715/9801349c/attachment.html>