[pulseaudio-discuss] [PATCH] launch: make pulseaudio.service properly order and require the socket
Tanu Kaskinen
tanuk at iki.fi
Wed Jul 20 20:46:18 UTC 2016
On Wed, 2016-07-20 at 09:57 -0400, Felipe Sateler wrote:
> This commit fixes two problems:
>
> 1. Because there are no implicit dependencies between sockets and services,
> the socket, as set up by systemd will race with the socket, as set up
> by the pulseaudio daemon. This can cause the pulseaudio.socket unit to
> fail (even though the pulseaudio service started just fine), which can
> confuse users.
> 2. While it is possible to use the service without the socket, it is not
> clear why it would be desirable. And a user installing pulseaudio and
> doing `systemctl --user start pulseaudio` will not get the socket
> started, which might be confusing and problematic if the server is to
> be restarted later on, as the client autospawn feature might kick in.
> ---
> src/daemon/systemd/user/pulseaudio.service.in | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/src/daemon/systemd/user/pulseaudio.service.in b/src/daemon/systemd/user/pulseaudio.service.in
> index df42fc3..0bd2a91 100644
> --- a/src/daemon/systemd/user/pulseaudio.service.in
> +++ b/src/daemon/systemd/user/pulseaudio.service.in
> @@ -1,5 +1,7 @@
> [Unit]
> Description=Sound Service
> +Requires=pulseaudio.socket
> +After=pulseaudio.socket
>
> [Service]
> # Note that notify will only work if --daemonize=no
Thanks! Applied. I also copied your commit message to the file as a
comment.
--
Tanu
More information about the pulseaudio-discuss
mailing list