[pulseaudio-discuss] [RFC][PATCH] improve missing handling in memblockq (was Re: stream wedged in non-playing state)

Pierre Ossman ossman at cendio.se
Fri Jul 22 11:03:52 UTC 2016


On 22/07/16 11:14, Arun Raghavan wrote:
>
>
> On Wed, 8 Jun 2016, at 03:49 PM, Pierre Ossman wrote:
>>
>> Hopefully that's sufficient for now?
>
> Yes, it is. I think the patches you posted look good. Just one question
> -- you moved missing and requested to being size_ts. Is there a reason
> you don't leave them as int64_ts and avoid the casts in comparison?
>

This was to properly solidify the concept that these can never be 
negative, which was the source of the earlier confusion. size_t seemed 
to be the type used in the rest of the API for such things.

Thanks for merging. Any chance you could have a look at my tunnel module 
patches next? :)

Regards
-- 
Pierre Ossman           Software Development
Cendio AB		http://cendio.com
Teknikringen 8		http://twitter.com/ThinLinc
583 30 Linköping	http://facebook.com/ThinLinc
Phone: +46-13-214600	http://plus.google.com/+CendioThinLinc

A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?


More information about the pulseaudio-discuss mailing list