[pulseaudio-discuss] [PATCH v2 0/9] Implement JSON parsing

Arun Raghavan arun at arunraghavan.net
Sat Jun 4 07:14:35 UTC 2016

On Thu, 2 Jun 2016, at 05:34 PM, Tanu Kaskinen wrote:
> On Wed, 2016-06-01 at 17:18 +0530, Arun Raghavan wrote:
> > This addresses Tanu's comments from the first series. I've squashed a
> > bunch of stuff that I thought made sense, and for some additions, I've
> > split out into new patches for easy review. I think it's fine to have it
> > this way since we'll be merging it all together anyway.
> > 
> > One thing I would welcome is patches, or even suggestions, of bad JSON
> > strings that we should be able to handle. It's quite easy to just throw
> > them into the test suite.
> > 
> > I've also verified that both json-test and format-test are valgrind
> > clean.
> Since I didn't find any other problems than the trivial-to-fix string
> parsing issue (plus an issue with the first patch using
> pa_json_object_free, which was added in the last patch), I made the
> modifications myself and pushed these patches to "next". Thanks for the
> patches!

Thanks for the thorough review!

-- Arun

More information about the pulseaudio-discuss mailing list