[pulseaudio-discuss] [PATCH 0/2] multichannel element_probe

David Henningsson david.henningsson at canonical.com
Tue Mar 1 10:41:54 UTC 2016


Looking at errors.ubuntu.com, a new crasher has climbed the charts a bit (at least
compared to other ones), starting with PA 7.0. The assertion failure occurs when
trying to set ALSA source volume. ( https://bugs.launchpad.net/bugs/1551610 )

While investigating that one, the only thing remotely related, seemed to be my change
w r t multi-channel volumes. Found a bug in that code; the first patch is a quick bug fix,
but I'm not at all sure it fixes the actual bug. Nevertheless the plan is to deploy it on
Ubuntu and see if the crash numbers go down or not. 

But then I was annoyed by the giant element_probe function being unreadable,
so I refactored it as well. I hope you like the change.

David Henningsson (2):
  alsa-mixer: Fix reference to too high channel numbers
  alsa-mixer: refactor element_probe

 src/modules/alsa/alsa-mixer.c | 437 ++++++++++++++++++++----------------------
 1 file changed, 207 insertions(+), 230 deletions(-)

-- 
2.7.0



More information about the pulseaudio-discuss mailing list