[pulseaudio-discuss] [PATCH 8/9] role-cork: add ducking functionality to stream-interaction.c

[Georg Chini]

On 17.03.2016 13:21, Tanu Kaskinen wrote:
> On Thu, 2015-03-26 at 21:54 +0100, Georg Chini wrote:
>> ---
>>   src/modules/stream-interaction.c | 54 +++++++++++++++++++++++++++++++---------
>>   1 file changed, 42 insertions(+), 12 deletions(-)
> module-role-ducking has one change that was added after you submitted
> this patch:
> https://cgit.freedesktop.org/pulseaudio/pulseaudio/commit/?id=d049c2941e6aef5ff33bcd0b4adece12289302b7
>
> If/when you resubmit this patch, please include that change. (I hope
> you still are willing to work on this despite the unreasonable time
> that it took for me to review this patch.)
>
> All preceding patches have been applied, by the way.
>
>

Thank you for your review. I will look into it on the weekend and 
re-send the patches.

> @@ -136,11 +155,11 @@ static inline void apply_interaction_to_sink(struct userdata *u, pa_sink *s, con
>               if (!interaction_applied)
>                   pa_hashmap_put(u->interaction_state, j, PA_INT_TO_PTR(1));
>   
> -            cork_stream(u, j, role, new_trigger);
> +            cork_or_duck(u, j, role, new_trigger, interaction_applied);
> This code is preceded by this if condition:
>
>          if (new_trigger && !corked && !j->muted) {
>
> So if the stream is corked or muted, no ducking will happen. That
> doesn't seem right.
>
I think this is the bug which is addressed in the additional (later) 
patch, I will also
check on the weekend.