[pulseaudio-discuss] [PATCH] role-ducking: Add support for ducking group

[Tanu Kaskinen]

On Fri, 2016-03-25 at 01:38 +0900, Sangchul Lee wrote:
> > > +    roles = pa_modargs_get_value(ma, "trigger_roles", NULL);
> > > +    if (roles) {
> > > +        const char *group_split_state = NULL;
> > > +        char *roles_in_group = NULL;
> > > +        i = 0;
> > > +        while ((roles_in_group = pa_split(roles, "/", &group_split_state))) {
> > > +            if (roles_in_group[0] != '\0') {
> > > +                const char *split_state = NULL;
> > > +                char *n = NULL;
> > > +                while ((n = pa_split(roles_in_group, ",", &split_state))) {
> > > +                    if (n[0] != '\0')
> > > +                        pa_idxset_put(u->trigger_roles[i], n, NULL);
> > > +                    else
> > > +                        pa_xfree(n);
> > 
> > If an empty string is given as a role name, I think that should be an
> > error.
> 
>  I understood your meaning that if an empty string is given as a role
> name, then not proceed next step and return error. Am I right?

Yes.

-- 
Tanu