[pulseaudio-discuss] [PATCH 1/6] log: journal: Prevent duplicate values for CODE_* fields

Tanu Kaskinen tanuk at iki.fi
Fri Mar 25 10:27:17 UTC 2016


On Sun, 2016-03-13 at 23:56 +0200, Ahmed S. Darwish wrote:
> sd_journal_send() implicitly add fields for the source file,
> function name and code line from where it's invoked. As code
> location fields CODE_FILE, CODE_LINE and CODE_FUNC are handled
> by PA's log module, we do not want the automatic values
> supplied by the sd_journal API.
> 
> Without suppressing these, both the actual log event source
> and the call to sd_journal_send() will be logged:
> 
>     $ journalctl -b -f -o json-pretty
>     [...]
>     CODE_FILE : [ pulsecore/log.c, pulsecore/module.c ],
>     CODE_LINE : [ 505, 181 ],
>     MESSAGE   : Failed to load module module-gconf
>     CODE_FUNC : [ pa_log_levelv_meta, pa_module_load ],
>     [...]
> 
> (Commit log adapted from abrt libreport commit d1eaae97f0287f)
> 
> Signed-off-by: Ahmed S. Darwish <darwish.07 at gmail.com>
> ---
>  src/pulsecore/log.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)

Thanks! Applied.

-- 
Tanu


More information about the pulseaudio-discuss mailing list