[pulseaudio-discuss] [PATCH] mainwindow: Don't add a border on the outermost vbox

Alexander E. Patrakov patrakov at gmail.com
Thu Mar 31 13:05:59 UTC 2016


31.03.2016 16:44, arun at accosted.net пишет:
> From: Arun Raghavan <git at arunraghavan.net>
>
> It adds a thick border around along the edges that looks quite ugly.

The patch does what it says, but the GtkNotebook tabs "glued" to the top 
of the window also don't look nice in MATE from my viewpoint. Caja's 
settings dialog (and some other MATE settings dialogs that use tabbed 
notebooks, as well as pitivi's Project Settings dialog) has this thick 
border. OTOH, MATE terminal does the ugly "tabs glued to the titlebar" 
thingy if one hides the menu, the same is also seen in linphone preferences.

So - no real (consistency-based) opinion here. If you can find anything 
in the HIG that explains that the border should not exist in this case, 
please add a link in the commit message, and/or quote directly, and push it.

-- 
Alexander E. Patrakov

> ---
>   src/pavucontrol.glade | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/src/pavucontrol.glade b/src/pavucontrol.glade
> index 219f5a2..66b5852 100644
> --- a/src/pavucontrol.glade
> +++ b/src/pavucontrol.glade
> @@ -698,7 +698,6 @@
>         <object class="GtkVBox" id="vbox20">
>           <property name="visible">True</property>
>           <property name="can_focus">False</property>
> -        <property name="border_width">12</property>
>           <property name="spacing">12</property>
>           <child>
>             <object class="GtkNotebook" id="notebook">
>


More information about the pulseaudio-discuss mailing list