[pulseaudio-discuss] [PATCH 2/2] stream: Frame-align divided audio segments

Tanu Kaskinen tanuk at iki.fi
Thu Nov 24 18:42:26 UTC 2016


On Tue, 2016-11-22 at 22:18 +0200, Ahmed S. Darwish wrote:
> Executing below command will not produce any audio:
> 
>   pacat  --channels=3 /dev/urandom
> 
> Turns out that pa_stream_write() breaks large audio buffers into
> segments of the maximum memblock size available -- a value which
> is not necessarily frame aligned.
> 
> Meanwhile the server discards any non-aligned client audio, as a
> security measure, due to some earlier reported daemon crashes.
> Thus divide sent audio to the expected aligned form.
> 
> CommitReference-1: 22827a5e1e62
> CommitReference-2: 150ace90f380
> BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=98475
> BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=77595
> Signed-off-by: Ahmed S. Darwish <darwish.07 at gmail.com>
> ---
>  src/pulse/stream.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

This looks good too. I now pushed both patches.

-- 
Tanu

https://www.patreon.com/tanuk


More information about the pulseaudio-discuss mailing list