[pulseaudio-discuss] Revisiting raop2 patches

[Tanu Kaskinen]

On Tue, 2016-10-25 at 22:47 +0200, Anton Lundin wrote:
> On 25 October, 2016 - Tanu Kaskinen wrote:
> > Are there any patches in the set that you'd be comfortable if I tagged
> > them with "Reviewed-by: Anton Lundin <glance at acc.umu.se>"?
> > 
> 
> I see what you did there Tanu =)
> 
> It sort of pushed my buttons so here we go:
> 
> 
> Support IPv6 address in pa_socket_client_new_string() (51d0fed4)
> Reviewed-by: Anton Lundin <glance at acc.umu.se>
> 
> rtp: Freeing ioline when disconnecting (256724cc)
> Reviewed-by: Anton Lundin <glance at acc.umu.se>
> 
> raop: Cosmetic fixes / Match coding style (1c9ccf74)
> Converts the already messed up ö in Högskolan to a Danish ö ø instead of
> the Swedish ö.
> The text looks to have bin messed up way back in time by Colin, and I've
> even saw traces that svn was involved, so what unholy things happed
> there we should probably just leave to future archaeological
> investigations to figure out.
> I'm sending a patch. Rebase / merge the coding style patch on top of that
> and I'm happy with it. 
> Reviewed-by: Anton Lundin <glance at acc.umu.se>
> 
> raop: Add pulsecore/core-utils a pa_str_in_list function (6835e40a)
> Reviewed-by: Anton Lundin <glance at acc.umu.se>
> 
> raop: Parse server capabilities on discovery (88cbec61)
> Why was the device part dropped from the device name? Nothing in the
> commit message says anything about that. The device part was dropped
> from the parsing to, even when some other no-op parsing blocks are left
> there for future reference.
> 
> Also, value is set to NULL in some parsing blocks and not in others.
> Some blocks strdup(value), and let avahi_free(value) free it, others
> "steal" value and set value = NULL. I'd feel more comfortable with all
> the code paths strdup'ing them selfs. Even, why not use pa_xstrdup ?
> 
> I think this patch is placed to early in the patch stack to. It adds
> options to the module-raop-sink which it can't parse.
> 
> rtp: New pa_rtsp_options function (1e7e70e4)
> Reviewed-by: Anton Lundin <glance at acc.umu.se>
> 
> rtp: Random seq number at the beginning of the session (8e3c0047)
> Reviewed-by: Anton Lundin <glance at acc.umu.se>
> 
> rtp: Introduce pa_rtsp_exec_ready() (5c4185ee)
> Reviewed-by: Anton Lundin <glance at acc.umu.se>

Thanks a lot! I pushed the patches that got your ok to the "next"
branch ("master" is frozen at the moment).

-- 
Tanu

https://www.patreon.com/tanuk