[pulseaudio-discuss] [PATCH] xen: Fixed possible memory leak.

[Deepak Srivastava]

module-xenpv-sink.c - In pa__init(...), memory for pa_modargs *ma is not released before returning from function.

Signed-off-by: Deepak Srivastava <srivastava.d at samsung.com>
---
 src/modules/xen/module-xenpv-sink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/modules/xen/module-xenpv-sink.c b/src/modules/xen/module-xenpv-sink.c
index 2612ec9..a26c6fc 100644
--- a/src/modules/xen/module-xenpv-sink.c
+++ b/src/modules/xen/module-xenpv-sink.c
@@ -398,7 +398,7 @@ int pa__init(pa_module*m) {
     /* user arguments override these */
     if (pa_modargs_get_sample_spec_and_channel_map(ma, &ss, &map, PA_CHANNEL_MAP_DEFAULT) < 0) {
         pa_log("Invalid sample format specification or channel map");
-        return 1;
+        goto fail;
     }
 
     /* Xen Basic init */
@@ -460,7 +460,7 @@ int pa__init(pa_module*m) {
     }
     if (ret!=NEGOTIATION_OK) {
         pa_log("Negotiation with Xen backend failed!");
-        return 1;
+        goto fail;
     }
 
     pa_sample_spec_snprint(strbuf, 100, &ss);
-- 
1.9.1