[pulseaudio-discuss] [PATCH] scripts: Add a pre-receive hook to catch invalid merge and WIP commits

Tanu Kaskinen tanuk at iki.fi
Fri Apr 7 07:37:40 UTC 2017


On Fri, 2017-04-07 at 12:34 +0530, Arun Raghavan wrote:
> On Fri, 7 Apr 2017, at 12:33 PM, Arun Raghavan wrote:
> > This should make sure we avoid merge commits from branches outside of PA
> > (we don't really have any, so this should avoid all merge commits). This
> > also catches "WIP" and such in the title to prevent accidental pushing
> > of those.
> > ---
> >  scripts/pre-receive.hook | 99
> >  ++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 99 insertions(+)
> >  create mode 100755 scripts/pre-receive.hook
> > 
> > I've not had a chance to test this -- if anyone is able to, that would be
> > great, and we can manually copy this over to deploy.
> > 
> > -- Arun
> > 
> > diff --git a/scripts/pre-receive.hook b/scripts/pre-receive.hook
> > new file mode 100755
> > index 0000000..8126cee
> > --- /dev/null
> > +++ b/scripts/pre-receive.hook
> > @@ -0,0 +1,99 @@
> > +#!/usr/bin/env python
> > +import sys
> > +import os
> > +import subprocess
> > +
> > +# Based on the same file in:
> > https://cgit.freedesktop.org/gstreamer/common
> > +# Manually deployed to
> > /srv/git.freedesktop.org/git/pulseaudio/pulseaudio.git/hooks
> > +
> > +# This server-side pre-receive hook is to be put and activated in all
> > modules
> > +# that depend on the common submodule.
> 
> I removed this lines already.

Did you remove also other references to this "common" thingy? Such as
error_badcommon?

-- 
Tanu

https://www.patreon.com/tanuk


More information about the pulseaudio-discuss mailing list