[pulseaudio-discuss] [PATCH] filter-apply: Fixed a stream moves to wrong sink(or source).

Georg Chini georg at chini.tk
Sat Apr 8 20:22:16 UTC 2017


On 07.04.2017 15:41, KimJeongYeon wrote:
> For example, a normal stream tried to attach to filter sink(or source), which
> filter loaded and managed by filter-apply. But, the stream become to attach to
> the ***master sink(or source)*** of filter module due to restoring operation.
> It seems should to be attached to the filter sink(or source) properly.
>
I do not think this is the right fix for the problem. With your patch, if
the property list of a stream without filter.apply set is changed, the
stream will still falsely be moved to the master sink.
I believe the right way to solve it would be to set the filter.apply 
property
and module_name when the sink_input_put hook is called and the sink is
a filter sink.

I also wonder why you use an enumeration when you only use one
of the values. A boolean is_put argument to process() would do.

Regards
             Georg


More information about the pulseaudio-discuss mailing list