[pulseaudio-discuss] [PATCH] filter-apply: Fixed a stream moves to wrong sink(or source).

[KimJeongYeon]

2017-04-10 22:59 GMT+09:00 Georg Chini <georg at chini.tk>:

> Thinking again, it looks that my suggestion also does not cover all cases.
> When the
> stream is moved away from the filter sink, it will have filter.apply set
> which it did not
> have initially. This is obviously wrong, so we need an additional property
> to indicate
> that filter.apply was set by module-filter-apply and that it can be removed
> when the
> stream moves away from the filter. Also I have only been talking about the
> put hook.
> The same applies to the move_finished hook.
>
> But you have been working with the code for a while now, so maybe you can
> come
> up with a better solution.

As you reviewed, there were not yet regarded scenarios.
I submit a patch v3 few minutes ago with covering all scenarios. (e.g
put / move / proplist change / unlink hooks) But, it become more
complicated.
Anyway, it does work well in my desktop environment.

>
> Also Arun might object to my idea. He asked me to summarize and wanted to
> reply
> on the list. So maybe you wait until he confirmed/rejected.
>

Sure.

Regards,
KimJeongYeon