[pulseaudio-discuss] [PATCH] tunnel-{sink, source}-new: Fix assertion when used with loopback or combine-sink

[Georg Chini]

On 17.08.2017 07:53, Tanu Kaskinen wrote:
> On Sat, 2017-08-12 at 22:29 +0200, Georg Chini wrote:
>> Currently pulseaudio crashes with an assertion in pa_rtpoll_item_new_asyncmsgq_read()
>> or pa_rtpoll_item_new_asyncmsgq_write() if a loopback is applied to a tunnel-new
>> sink or source, because tunnel-{sink,source}-new do not set thread_info.rtpoll.
>> The same applies to module-combine-sink and module-rtp-recv.
>>
>> This patch is not a complete fix for the problem but provides a temporary band-aid
>> by initializing thread_info.rtpoll properly. The rtpoll created is never run, but
>> loopback and combine-sink nevertheless work, see comments in the code.
>>
>> This patch does not work for module-rtp-recv, but using rtp-recv with a remote
>> sink does not seem to make a lot of sense anyway.
>>
>> Bug link: https://bugs.freedesktop.org/show_bug.cgi?id=73429
>> ---
>>   src/modules/module-tunnel-sink-new.c   | 15 +++++++++++++++
>>   src/modules/module-tunnel-source-new.c | 12 ++++++++++++
>>   2 files changed, 27 insertions(+)
> Thanks! Pushed to next.
>
Should it not go to master as well because it fixes a crash?