[pulseaudio-discuss] [PATCH] sink, source: Don't finish move if unlink happens after pa_*_move_all_start()

[Georg Chini]

On 03.12.2017 22:08, Tanu Kaskinen wrote:
> On Sat, 2017-12-02 at 23:19 +0100, Georg Chini wrote:
>> When a sink input is unlinked between the calls to pa_sink_move_all_start() and
>> pa_sink_move_all_finish(), pa_sink_move_all_finish() tried to finish the move
>> of the already unlinked sink input, which lead to an assertion in
>> pa_sink_input_finish_move(). The same applies for the source side.
>>
>> This patch fixes the problem by checking the state of the sink input or
>> source output in pa_*_move_all_finish().
>>
>> Bug report: https://bugs.freedesktop.org/show_bug.cgi?id=103752
>>
> The unref() calls are unnecessarily duplicated in both of the if-else
> branches. Otherwise looks good, thanks for the fix!
>
Thanks, fixed the duplication and pushed it.