[pulseaudio-discuss] [PATCH v2] bluetooth: Make use of getsockopt() to determine MTU configurable

Georg Chini georg at chini.tk
Tue Feb 14 09:52:41 UTC 2017


On 14.02.2017 10:42, Tanu Kaskinen wrote:
> On Sat, 2017-02-04 at 20:32 +0100, Georg Chini wrote:
>> A recent patch changed the MTU size from the default value of 48 to the value
>> returned by getsockopt(). This breaks HSP for some setups. To circumvent the
>> problem, this patch introduces a boolean parameter "autodetect_mtu" for
>> module-bluetooth-discover, module-bluez5-discover and module-bluez5-device to
>> make this use of getsockopt() configurable.
>> The parameter defaults to false, so backend-native returns to the old behavior
>> of using 48 as default MTU.
> I think defaulting to true would be better. Defaulting to false is
> never going to make all hardware work out of the box, but defaulting to
> true may someday always work, since the kernel developers seem to be
> willing to add hardware specific quirks.
>
> The sco_opt variable declaration could be moved inside this if block.
>
> I'll make these small changes myself and push the patch.
>
Thanks.



More information about the pulseaudio-discuss mailing list