[pulseaudio-discuss] [PATCH] backend-native: rebase of patch to support HSP HeadeSet profile

Georg Chini georg at chini.tk
Tue Feb 14 12:07:47 UTC 2017

On 14.02.2017 12:28, Tanu Kaskinen wrote:
> On Tue, 2017-02-14 at 12:24 +0100, Georg Chini wrote:
>> On 14.02.2017 12:08, Tanu Kaskinen wrote:
>>> On Sat, 2017-02-04 at 20:47 +0100, Georg Chini wrote:
>>>> Subject: [PATCH] backend-native: rebase of patch to support HSP HeadeSet profile
>>> Usually it's not interesting that a patch was rebased. In this case
>>> it's good to mention it in the commit message, since the one who did
>>> the rebasing is different from the original author of the patch, but
>>> the patch heading is not the right place for that information.
>>> You seem to have replaced Wim with yourself as the main patch author.
>>> Was the rebasing effort large enough to justify that?
>> Have I? That was not my intention.
> Yes. You can probably can see in your git log, because otherwise git
> send-email should have added "From:" in the beginning of the commit
> message.

OK, I'll figure out what I need to do to have the correct author.

>>>> This is a rebase of Wim Taymans patch to support the HSP headset role that has
>>>> somehow been forgotten. Original patch can be found at
>>>> https://lists.freedesktop.org/archives/pulseaudio-discuss/2015-February/023242.html
>>> This is how it happened: Arun reviewed the patch, but provided the
>>> feedback in IRC, so there was no permanent record of the review. Since
>>> the patch was already reviewed, nobody else reviewed it later, but no
>>> new version was submitted either.
>>> I can review this new submission, but first I want to be able to apply
>>> the patch locally. It doesn't seem to apply cleanly on master. Can you
>>> clarify which branch the patch is expected to be applied on?
>> Mh, since it was the third bluetooth patch I submitted, it probably needs
>> the  patch "Make use of getsockopt() to determine MTU configurable".
>> Since you already pushed this one, I would expect it to apply cleanly.
>> If it still does not apply, let me know, I'll send an updated patch then.
> It still doesn't apply. Maybe the changes that I did are the culprit.
I'll pull a fresh tree and do it again later today or tomorrow. Because
the remaining two patches depend on this one, I'll will also send them 

More information about the pulseaudio-discuss mailing list